netdev - Re: [PATCH v2 iproute2-next] devlink: Add board.serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 20:34:50 +0530
From:   Vasundhara Volam <vasundhara-v.volam@...adcom.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        Netdev <netdev@...r.kernel.org>, dsahern@...il.com,
        David Miller <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand.

On Wed, Jul 8, 2020 at 5:05 PM Jiri Pirko <jiri@...nulli.us> wrote:
>
> Wed, Jul 08, 2020 at 11:40:12AM CEST, vasundhara-v.volam@...adcom.com wrote:
> >On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger
> ><stephen@...workplumber.org> wrote:
> >>
> >> On Mon, 29 Jun 2020 13:13:04 +0530
> >> Vasundhara Volam <vasundhara-v.volam@...adcom.com> wrote:
> >>
> >> > Add support for reading board serial_number to devlink info
> >> > subcommand. Example:
> >> >
> >> > $ devlink dev info pci/0000:af:00.0 -jp
> >> > {
> >> >     "info": {
> >> >         "pci/0000:af:00.0": {
> >> >             "driver": "bnxt_en",
> >> >             "serial_number": "00-10-18-FF-FE-AD-1A-00",
> >> >             "board.serial_number": "433551F+172300000",
> >> >             "versions": {
> >> >                 "fixed": {
> >> >                     "board.id": "7339763 Rev 0.",
> >> >                     "asic.id": "16D7",
> >> >                     "asic.rev": "1"
> >> >                 },
> >> >                 "running": {
> >> >                     "fw": "216.1.216.0",
> >> >                     "fw.psid": "0.0.0",
> >> >                     "fw.mgmt": "216.1.192.0",
> >> >                     "fw.mgmt.api": "1.10.1",
> >> >                     "fw.ncsi": "0.0.0.0",
> >> >                     "fw.roce": "216.1.16.0"
> >> >                 }
> >> >             }
> >> >         }
> >> >     }
> >> > }
> >>
> >> Although this is valid JSON, many JSON style guides do not allow
> >> for periods in property names. This is done so libraries can use
> >> dot notation to reference objects.
> >Okay, I will modify the name to board_serial_number and resend the
> >patch. Thanks.
>
> Does not make sense. We have plenty of other items with ".". Having one
> without it does not resolve anything, only brings inconsistency. Please
> have ".".
Okay so keeping the patch as-is.

>
>
> >
> >>
> >> Also the encoding of PCI is problematic
> >>
> >>