netdev - Re: [PATCH bpf-next v2 4/4] selftests: bpf: remove unused bpf_map_def

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 10:56:14 +0900
From:   "Daniel T. Lee" <danieltimlee@...il.com>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Yonghong Song <yhs@...com>, Martin KaFai Lau <kafai@...com>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 4/4] selftests: bpf: remove unused
 bpf_map_def_legacy struct

On Wed, Jul 8, 2020 at 4:00 AM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Tue, Jul 7, 2020 at 11:49 AM Daniel T. Lee <danieltimlee@...il.com> wrote:
> >
> > samples/bpf no longer use bpf_map_def_legacy and instead use the
> > libbpf's bpf_map_def or new BTF-defined MAP format. This commit removes
> > unused bpf_map_def_legacy struct from selftests/bpf/bpf_legacy.h.
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@...il.com>
> > ---
>
> Next time please don't forget to keep Ack's you've received on
> previous revision.
>

I'll keep that in mind.

Thank you for your time and effort for the review.
Daniel.

> >  tools/testing/selftests/bpf/bpf_legacy.h | 14 --------------
> >  1 file changed, 14 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/bpf_legacy.h b/tools/testing/selftests/bpf/bpf_legacy.h
> > index 6f8988738bc1..719ab56cdb5d 100644
> > --- a/tools/testing/selftests/bpf/bpf_legacy.h
> > +++ b/tools/testing/selftests/bpf/bpf_legacy.h
> > @@ -2,20 +2,6 @@
> >  #ifndef __BPF_LEGACY__
> >  #define __BPF_LEGACY__
> >
> > -/*
> > - * legacy bpf_map_def with extra fields supported only by bpf_load(), do not
> > - * use outside of samples/bpf
> > - */
> > -struct bpf_map_def_legacy {
> > -       unsigned int type;
> > -       unsigned int key_size;
> > -       unsigned int value_size;
> > -       unsigned int max_entries;
> > -       unsigned int map_flags;
> > -       unsigned int inner_map_idx;
> > -       unsigned int numa_node;
> > -};
> > -
> >  #define BPF_ANNOTATE_KV_PAIR(name, type_key, type_val)         \
> >         struct ____btf_map_##name {                             \
> >                 type_key key;                                   \
> > --
> > 2.25.1
> >