netdev - RE: [Intel-wired-lan] [PATCH net-next 3/4] i40e, xsk: increase budget for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB2145C84FFB906F0FA2692D488C670@BN6PR1101MB2145.namprd11.prod.outlook.com>
Date:   Wed, 8 Jul 2020 20:44:30 +0000
From:   "Bowers, AndrewX" <andrewx.bowers@...el.com>
To:     "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next 3/4] i40e, xsk: increase budget
 for AF_XDP path

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Björn Töpel
> Sent: Thursday, July 2, 2020 8:37 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; bpf@...r.kernel.org; Topel, Bjorn
> <bjorn.topel@...el.com>; Karlsson, Magnus <magnus.karlsson@...el.com>
> Subject: [Intel-wired-lan] [PATCH net-next 3/4] i40e, xsk: increase budget for
> AF_XDP path
> 
> From: Björn Töpel <bjorn.topel@...el.com>
> 
> The napi_budget, meaning the number of received packets that are allowed
> to be processed for each napi invocation, takes into consideration that each
> received packet is aimed for the kernel networking stack.
> 
> That is not the case for the AF_XDP receive path, where the cost of each
> packet is significantly less. Therefore, this commit disregards the napi budget
> and increases it to 256. Processing 256 packets targeted for AF_XDP is still less
> work than 64 (napi budget) packets going to the kernel networking stack.
> 
> The performance for the rx_drop scenario is up 7%.
> 
> Signed-off-by: Björn Töpel <bjorn.topel@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Tested-by: Andrew Bowers <andrewx.bowers@...el.com>