netdev - Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96a4cb06-c4d2-2aec-2d63-dfcd6691e05a@gmail.com>
Date:   Tue, 7 Jul 2020 22:26:49 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Huazhong Tan <tanhuazhong@...wei.com>, davem@...emloft.net,
        willemb@...gle.com
Cc:     netdev@...r.kernel.org, linuxarm@...wei.com, kuba@...nel.org
Subject: Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to
 NETIF_F_SOFTWARE_GSO



On 7/7/20 8:48 PM, Huazhong Tan wrote:
> Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with


s/NETIF_F_SOFTWARE_GSO/NETIF_F_GSO_UDP_L4/

> a software fallback.  This allows UDP GSO to be used even if
> the hardware does not support it, and for virtual device such
> as VxLAN device, this UDP segmentation will be postponed to
> physical device.

Is GSO stack or hardware USO able to perform this segmentation,
with vxlan (or other) added encapsulation ?

What about code in net/core/tso.c (in net-next tree) ?

> 
> Signed-off-by: Huazhong Tan <tanhuazhong@...wei.com>
> ---
>  include/linux/netdev_features.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> index 2cc3cf8..c7eef16 100644
> --- a/include/linux/netdev_features.h
> +++ b/include/linux/netdev_features.h
> @@ -207,7 +207,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start)
>  				 NETIF_F_FSO)
>  
>  /* List of features with software fallbacks. */
> -#define NETIF_F_GSO_SOFTWARE	(NETIF_F_ALL_TSO | \
> +#define NETIF_F_GSO_SOFTWARE	(NETIF_F_ALL_TSO | NETIF_F_GSO_UDP_L4 | \
>  				 NETIF_F_GSO_SCTP)
>  
>  /*
>