netdev - Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+FuTSeJMLW=HHrDjenEeinDc6RZTEynjkQWY6cPnOB-FbOTnA@mail.gmail.com>
Date:   Thu, 9 Jul 2020 09:34:42 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     tanhuazhong <tanhuazhong@...wei.com>
Cc:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        David Miller <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linuxarm@...wei.com, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC net-next 1/2] udp: add NETIF_F_GSO_UDP_L4 to NETIF_F_SOFTWARE_GSO

On Wed, Jul 8, 2020 at 10:49 PM tanhuazhong <tanhuazhong@...wei.com> wrote:
>
>
>
> On 2020/7/8 20:11, Willem de Bruijn wrote:
> > On Tue, Jul 7, 2020 at 11:50 PM Huazhong Tan <tanhuazhong@...wei.com> wrote:
> >>
> >> Add NETIF_F_SOFTWARE_GSO to the the list of GSO features with
> >> a software fallback.  This allows UDP GSO to be used even if
> >> the hardware does not support it,
> >
> > That is already the case if just calling UDP_SEGMENT.
> >
> > It seems the specific goal here is to postpone segmentation when
> > going through a vxlan device?
> >
>
> yes. without this patch, the segmentation is handled before calling
> virtual device's .ndo_start_xmit.
> Like TSO, UDP GSO also should be handle as later as possible?

Sure, but the commit message makes it sounds as if UDP GSO cannot be
used if hardware does not support it right now.