[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <SN6PR11MB2575FC91B5567824F521C60CF6640@SN6PR11MB2575.namprd11.prod.outlook.com>
Date: Thu, 9 Jul 2020 14:40:31 +0000
From: "G Jaya Kumaran, Vineetha" <vineetha.g.jaya.kumaran@...el.com>
To: Andrew Lunn <andrew@...n.ch>
CC: "davem@...emloft.net" <davem@...emloft.net>,
"kuba@...nel.org" <kuba@...nel.org>,
"mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"Voon, Weifeng" <weifeng.voon@...el.com>,
"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
"Ong, Boon Leong" <boon.leong.ong@...el.com>
Subject: RE: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay
> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Tuesday, July 7, 2020 9:08 PM
> To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@...el.com>
> Cc: davem@...emloft.net; kuba@...nel.org; mcoquelin.stm32@...il.com;
> robh+dt@...nel.org; netdev@...r.kernel.org; devicetree@...r.kernel.org;
> Voon, Weifeng <weifeng.voon@...el.com>; Kweh, Hock Leong
> <hock.leong.kweh@...el.com>; Ong, Boon Leong <boon.leong.ong@...el.com>
> Subject: Re: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay
>
> > + mdio0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "snps,dwmac-mdio";
> > +
> > + ethernet-phy@0 {
> > + compatible = "ethernet-phy-id0141.0dd0",
> > + "ethernet-phy-ieee802.3-c22";
>
> You only need to provide the phy-id when the PHY is broken and registers 2 and
> 3 don't contain a valid ID. And c22 is the default, so also not needed. The
> Marvell 88E1510 will work without these compatible strings.
>
> Andrew
Thanks Andrew, I will change this in v2.
Powered by blists - more mailing lists