| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jul 2020 00:32:39 +0800
From: kernel test robot <lkp@...el.com>
To: Maxim Mikityanskiy <maximmi@...lanox.com>,
Magnus Karlsson <magnus.karlsson@...el.com>
Cc: kbuild-all@...ts.01.org,
Björn Töpel <bjorn.topel@...el.com>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Network Development <netdev@...r.kernel.org>,
Jonathan Lemon <jonathan.lemon@...il.com>,
bpf <bpf@...r.kernel.org>, jeffrey.t.kirsher@...el.com,
Fijalkowski Maciej <maciej.fijalkowski@...el.com>,
Maciej Fijalkowski <maciejromanfijalkowski@...il.com>
Subject: Re: [PATCH 1/2] xsk: i40e: ice: ixgbe: mlx5: pass buffer pool to
driver instead of umem
Hi Maxim,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200709]
[cannot apply to linus/master v5.8-rc4 v5.8-rc3 v5.8-rc2 v5.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Maxim-Mikityanskiy/xsk-i40e-ice-ixgbe-mlx5-pass-buffer-pool-to-driver-instead-of-umem/20200709-225826
base: b966b5cf71790478be7726593d011cb085a97a94
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_xsk_map_pool':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:14:30: error: 'struct xsk_buff_pool' has no member named 'umem'
14 | return xsk_buff_dma_map(pool->umem, dev, 0);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_xsk_unmap_pool':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:20:32: error: 'struct xsk_buff_pool' has no member named 'umem'
20 | return xsk_buff_dma_unmap(pool->umem, 0);
| ^~
>> drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:20:9: warning: 'return' with a value, in function returning void [-Wreturn-type]
20 | return xsk_buff_dma_unmap(pool->umem, 0);
| ^~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:17:13: note: declared here
17 | static void mlx5e_xsk_unmap_pool(struct mlx5e_priv *priv,
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_xsk_is_pool_sane':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:67:35: error: 'struct xsk_buff_pool' has no member named 'umem'
67 | return xsk_umem_get_headroom(pool->umem) <= 0xffff &&
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:68:31: error: 'struct xsk_buff_pool' has no member named 'umem'
68 | xsk_umem_get_chunk_size(pool->umem) <= 0xffff;
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_build_xsk_param':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:73:44: error: 'struct xsk_buff_pool' has no member named 'umem'
73 | xsk->headroom = xsk_umem_get_headroom(pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:74:48: error: 'struct xsk_buff_pool' has no member named 'umem'
74 | xsk->chunk_size = xsk_umem_get_chunk_size(pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_xsk_is_pool_sane':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:69:1: warning: control reaches end of non-void function [-Wreturn-type]
69 | }
| ^
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c: In function 'mlx5e_xsk_map_pool':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/pool.c:15:1: warning: control reaches end of non-void function [-Wreturn-type]
15 | }
| ^
--
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:63:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h: In function 'mlx5e_xsk_page_alloc_pool':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h:25:45: error: 'struct xsk_buff_pool' has no member named 'umem'
25 | dma_info->xsk = xsk_buff_alloc(rq->xsk_pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h: In function 'mlx5e_xsk_update_rx_wakeup':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h:41:45: error: 'struct xsk_buff_pool' has no member named 'umem'
41 | if (!xsk_umem_uses_need_wakeup(rq->xsk_pool->umem))
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h:45:38: error: 'struct xsk_buff_pool' has no member named 'umem'
45 | xsk_set_rx_need_wakeup(rq->xsk_pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.h:47:40: error: 'struct xsk_buff_pool' has no member named 'umem'
47 | xsk_clear_rx_need_wakeup(rq->xsk_pool->umem);
| ^~
In file included from drivers/net/ethernet/mellanox/mlx5/core/en_main.c:64:
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.h: In function 'mlx5e_xsk_update_tx_wakeup':
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.h:18:45: error: 'struct xsk_buff_pool' has no member named 'umem'
18 | if (!xsk_umem_uses_need_wakeup(sq->xsk_pool->umem))
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.h:22:40: error: 'struct xsk_buff_pool' has no member named 'umem'
22 | xsk_clear_tx_need_wakeup(sq->xsk_pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/tx.h:24:38: error: 'struct xsk_buff_pool' has no member named 'umem'
24 | xsk_set_tx_need_wakeup(sq->xsk_pool->umem);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_alloc_rq':
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:521:37: error: 'struct xsk_buff_pool' has no member named 'umem'
521 | xsk_buff_set_rxq_info(rq->xsk_pool->umem, &rq->xdp_rxq);
| ^~
drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_xdp':
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:4547:7: error: 'XDP_SETUP_XSK_POOL' undeclared (first use in this function); did you mean 'XDP_SETUP_XSK_UMEM'?
4547 | case XDP_SETUP_XSK_POOL:
| ^~~~~~~~~~~~~~~~~~
| XDP_SETUP_XSK_UMEM
drivers/net/ethernet/mellanox/mlx5/core/en_main.c:4547:7: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:4548:44: error: 'struct <anonymous>' has no member named 'pool'
4548 | return mlx5e_xsk_setup_pool(dev, xdp->xsk.pool,
| ^
vim +4547 drivers/net/ethernet/mellanox/mlx5/core/en_main.c
4538
4539 static int mlx5e_xdp(struct net_device *dev, struct netdev_bpf *xdp)
4540 {
4541 switch (xdp->command) {
4542 case XDP_SETUP_PROG:
4543 return mlx5e_xdp_set(dev, xdp->prog);
4544 case XDP_QUERY_PROG:
4545 xdp->prog_id = mlx5e_xdp_query(dev);
4546 return 0;
> 4547 case XDP_SETUP_XSK_POOL:
> 4548 return mlx5e_xsk_setup_pool(dev, xdp->xsk.pool,
4549 xdp->xsk.queue_id);
4550 default:
4551 return -EINVAL;
4552 }
4553 }
4554
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Download attachment ".config.gz" of type "application/gzip" (73754 bytes)
Powered by blists - more mailing lists