netdev - Re: [Patch net] net_sched: fix a memory leak in atm_tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200709.123226.1790509373997909025.davem@davemloft.net>
Date:   Thu, 09 Jul 2020 12:32:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org,
        syzbot+d411cff6ab29cc2c311b@...kaller.appspotmail.com,
        jhs@...atatu.com, jiri@...nulli.us
Subject: Re: [Patch net] net_sched: fix a memory leak in atm_tc_init()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Wed,  8 Jul 2020 20:13:59 -0700

> When tcf_block_get() fails inside atm_tc_init(),
> atm_tc_put() is called to release the qdisc p->link.q.
> But the flow->ref prevents it to do so, as the flow->ref
> is still zero.
> 
> Fix this by moving the p->link.ref initialization before
> tcf_block_get().
> 
> Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
> Reported-and-tested-by: syzbot+d411cff6ab29cc2c311b@...kaller.appspotmail.com
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Cc: Jiri Pirko <jiri@...nulli.us>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.