netdev - Re: [PATCH v2 bpf 0/2] bpf: net: Fixes in sk_user_data of reuseport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f84a5aeb-9040-f7dc-d4ed-63bd6d764878@iogearbox.net>
Date:   Thu, 9 Jul 2020 22:07:06 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>, kernel-team@...com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 bpf 0/2] bpf: net: Fixes in sk_user_data of
 reuseport_array

On 7/9/20 8:10 AM, Martin KaFai Lau wrote:
> This set fixes two issues on sk_user_data when a sk is added to
> a reuseport_array.
> 
> The first patch is to avoid the sk_user_data being copied
> to a cloned sk.  The second patch avoids doing bpf_sk_reuseport_detach()
> on sk_user_data that is not managed by reuseport_array.
> 
> Since the changes are mostly related to bpf reuseport_array, so it is
> currently tagged as bpf fixes.
> 
> v2:
> - Avoid ~3UL (Andrii)
> 
> Martin KaFai Lau (2):
>    bpf: net: Avoid copying sk_user_data of reuseport_array during
>      sk_clone
>    bpf: net: Avoid incorrect bpf_sk_reuseport_detach call
> 
>   include/net/sock.h           |  3 ++-
>   kernel/bpf/reuseport_array.c | 14 ++++++++++----
>   2 files changed, 12 insertions(+), 5 deletions(-)
> 

Applied, thanks!