netdev - Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for sk_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200709.162606.1568687795941901793.davem@davemloft.net>
Date:   Thu, 09 Jul 2020 16:26:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     linux@...ck-us.net, netdev@...r.kernel.org, cam@...-zeon.de,
        pgwipeout@...il.com, lufq.fnst@...fujitsu.com, dsonck92@...il.com,
        qiang.zhang@...driver.com, t.lamprecht@...xmox.com,
        daniel@...earbox.net, lizefan@...wei.com, tj@...nel.org,
        guro@...com
Subject: Re: [Patch net v2] cgroup: fix cgroup_sk_alloc() for
 sk_clone_lock()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu, 9 Jul 2020 12:19:40 -0700

> Make sure you test the second patch I sent, not the first one. The
> first one is still incomplete and ugly too. The two bits must be the
> last two, so correcting the if test is not sufficient, we have to
> fix the whole bitfield packing.

That is definitely the correct thing to do, I'm going to apply that
bitfield packing patch as-is because I have to get a pull request to
Linus and I don't want to break big endian like this.