netdev - Re: [net-next PATCH 1/3 v1] net: dsa: rtl8366: Fix VLAN semantics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15074ccd-97de-7417-4d11-3d1bcaf4c70d@gmail.com>
Date:   Wed, 8 Jul 2020 19:13:56 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Cc:     DENG Qingfang <dqfext@...il.com>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [net-next PATCH 1/3 v1] net: dsa: rtl8366: Fix VLAN semantics



On 7/8/2020 1:44 PM, Linus Walleij wrote:
> The RTL8366 would not handle adding new members (ports) to
> a VLAN: the code assumed that ->port_vlan_add() was only
> called once for a single port. When intializing the
> switch with .configure_vlan_while_not_filtering set to
> true, the function is called numerous times for adding
> all ports to VLAN1, which was something the code could
> not handle.
> 
> Alter rtl8366_set_vlan() to just |= new members and
> untagged flags to 4k and MC VLAN table entries alike.
> This makes it possible to just add new ports to a
> VLAN.
> 
> Put in some helpful debug code that can be used to find
> any further bugs here.
> 
> Cc: DENG Qingfang <dqfext@...il.com>
> Cc: Mauri Sandberg <sandberg@...lfence.com>
> Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian