netdev - Re: [PATCH bpf-next] libbpf: fix memory leak and optimize BTF sanitization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <102d6d82-5acb-da0b-824b-452d8315957d@iogearbox.net>
Date:   Fri, 10 Jul 2020 16:29:07 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Andrii Nakryiko <andriin@...com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org, ast@...com
Cc:     andrii.nakryiko@...il.com, kernel-team@...com
Subject: Re: [PATCH bpf-next] libbpf: fix memory leak and optimize BTF
 sanitization

On 7/10/20 3:10 AM, Andrii Nakryiko wrote:
> Coverity's static analysis helpfully reported a memory leak introduced by
> 0f0e55d8247c ("libbpf: Improve BTF sanitization handling"). While fixing it,
> I realized that btf__new() already creates a memory copy, so there is no need
> to do this. So this patch also fixes misleading btf__new() signature to make
> data into a `const void *` input parameter. And it avoids unnecessary memory
> allocation and copy in BTF sanitization code altogether.
> 
> Fixes: 0f0e55d8247c ("libbpf: Improve BTF sanitization handling")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

LGTM, applied, thanks!