netdev - Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d4427cc-a57c-ca99-1119-1674d509ba9d@iogearbox.net>
Date:   Fri, 10 Jul 2020 17:14:28 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>, ast@...nel.org,
        davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
        john.fastabend@...il.com, mchehab+huawei@...nel.org,
        robh@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
> Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>>> Rationale:
>>> Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>>> which has nothing to do with XDP.
>>>
>>> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
>>> ---
>>>   See also: https://lore.kernel.org/lkml/20200709132607.7fb42415@carbon/
>>>
>>>   MAINTAINERS | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 1d4aa7f942de..2bb7feb838af 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>>>   F:    kernel/bpf/cpumap.c
>>>   F:    kernel/bpf/devmap.c
>>>   F:    net/core/xdp.c
>>> -N:    xdp
>>> -K:    xdp
>>> +N:    (?:\b|_)xdp(?:\b|_)
>>> +K:    (?:\b|_)xdp(?:\b|_)
>>
>> Please also include \W to generally match on non-alphanumeric char given you
>> explicitly want to avoid [a-z0-9] around the term xdp.
> Aren't \W, ^ and $ already covered by \b?

Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
In case this goes via net or net-next tree:

Acked-by: Daniel Borkmann <daniel@...earbox.net>