netdev - Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200710085056.6deb411a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 10 Jul 2020 08:50:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zhi Li <lizhi01@...ngson.cn>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, davem@...emloft.net,
        mcoquelin.stm32@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lixuefeng@...ngson.cn,
        chenhc@...ote.com, jiaxun.yang@...goat.com, yangtiezhu@...ngson.cn,
        Hongbin Li <lihongbin@...ngson.cn>
Subject: Re: [PATCH] stmmac: pci: Add support for LS7A bridge chip

On Fri, 10 Jul 2020 16:51:50 +0800 Zhi Li wrote:
> Add gmac platform data to support LS7A bridge chip.
> 
> Co-developed-by: Hongbin Li <lihongbin@...ngson.cn>
> Signed-off-by: Hongbin Li <lihongbin@...ngson.cn>
> Signed-off-by: Zhi Li <lizhi01@...ngson.cn>

This appears to not build with allmodconfig:

../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:22:62: note: expected ‘struct plat_stmmacenet_data *’ but argument is of type ‘struct plat_stmmacenent_data *’
   22 | static void common_default_data(struct plat_stmmacenet_data *plat)
      |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:145:6: error: invalid use of undefined type ‘struct plat_stmmacenent_data’
  145 |  plat->bus_id = pci_dev_id(pdev);
      |      ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:146:6: error: invalid use of undefined type ‘struct plat_stmmacenent_data’
  146 |  plat->phy_addr = 0;
      |      ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:147:6: error: invalid use of undefined type ‘struct plat_stmmacenent_data’
  147 |  plat->interface = PHY_INTERFACE_MODE_GMII;
      |      ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:149:6: error: invalid use of undefined type ‘struct plat_stmmacenent_data’
  149 |  plat->dma_cfg->pbl = 32;
      |      ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:150:6: error: invalid use of undefined type ‘struct plat_stmmacenent_data’
  150 |  plat->dma_cfg->pblx8 = true;
      |      ^~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: At top level:
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:11: error: initialization of ‘int (*)(struct pci_dev *, struct plat_stmmacenet_data *)’ from incompatible pointer type ‘int (*)(struct pci_dev *, struct plat_stmmacenent_data *)’ [-Werror=incompatible-pointer-types]
  156 |  .setup = loongson_default_data;
      |           ^~~~~~~~~~~~~~~~~~~~~
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:11: note: (near initialization for ‘loongson_pci_info.setup’)
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:156:32: error: expected ‘}’ before ‘;’ token
  156 |  .setup = loongson_default_data;
      |                                ^
../drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:155:51: note: to match this ‘{’
  155 | static struct stmmac_pci_info loongson_pci_info = {
      |                                                   ^
cc1: some warnings being treated as errors
make[6]: *** [drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o] Error 1
make[5]: *** [drivers/net/ethernet/stmicro/stmmac] Error 2
make[4]: *** [drivers/net/ethernet/stmicro] Error 2
make[3]: *** [drivers/net/ethernet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [drivers] Error 2
make: *** [__sub-make] Error 2