netdev - Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and function changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C1F3BC8C-AFAD-4AB4-8329-A48F4AD0E60B@amazon.com>
Date:   Fri, 10 Jul 2020 20:31:58 +0000
From:   "Machulsky, Zorik" <zorik@...zon.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "Kiyanovski, Arthur" <akiyano@...zon.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Belgazal, Netanel" <netanel@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Dagan, Noam" <ndagan@...zon.com>,
        "Agroskin, Shay" <shayagr@...zon.com>,
        "Jubran, Samih" <sameehj@...zon.com>
Subject: Re: [PATCH V1 net-next 6/8] net: ena: enable support of rss hash key and
 function changes



On 7/10/20, 1:05 PM, "Jakub Kicinski" <kuba@...nel.org> wrote:

    On Fri, 10 Jul 2020 19:53:46 +0000 Machulsky, Zorik wrote:
    > On 7/9/20, 1:24 PM, "Jakub Kicinski" <kuba@...nel.org> wrote:
    >
    >     On Thu, 9 Jul 2020 22:05:01 +0300 akiyano@...zon.com wrote:
    >     > From: Arthur Kiyanovski <akiyano@...zon.com>
    >     >
    >     > Add the rss_configurable_function_key bit to driver_supported_feature.
    >     >
    >     > This bit tells the device that the driver in question supports the
    >     > retrieving and updating of RSS function and hash key, and therefore
    >     > the device should allow RSS function and key manipulation.
    >     >
    >     > Signed-off-by: Arthur Kiyanovski <akiyano@...zon.com>
    >
    >     Is this a fix of the previous patches? looks strange to just start
    >     advertising a feature bit but not add any code..
    >
    > The previous related commits were merged already:
    > 0af3c4e2eab8 net: ena: changes to RSS hash key allocation
    > c1bd17e51c71 net: ena: change default RSS hash function to Toeplitz
    > f66c2ea3b18a net: ena: allow setting the hash function without changing the key
    > e9a1de378dd4 net: ena: fix error returning in ena_com_get_hash_function()
    > 80f8443fcdaa net: ena: avoid unnecessary admin command when RSS function set fails
    > 6a4f7dc82d1e net: ena: rss: do not allocate key when not supported
    > 0d1c3de7b8c7 net: ena: fix incorrect default RSS key

    These commits are in net.

    > This commit was not included by mistake, so we are adding it now.

    You're adding it to net-next.
This commit actually enables a feature after it was fixed by previous commits, therefore we thought
that net-next could be a right place. But if you think it should go to net, we'll go ahead and resubmit 
it there. Thanks for your comments.