netdev - Re: [PATCH v4 net-next] inet: Remove an unnecessary argument of syn_ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200710.143850.1365535614159124305.davem@davemloft.net>
Date:   Fri, 10 Jul 2020 14:38:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kuniyu@...zon.co.jp
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        edumazet@...gle.com, netdev@...r.kernel.org, kuni1840@...il.com,
        benh@...zon.com, osa-contribution-log@...zon.com, ja@....bg
Subject: Re: [PATCH v4 net-next] inet: Remove an unnecessary argument of
 syn_ack_recalc().

From: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Date: Sat, 11 Jul 2020 00:57:59 +0900

> Commit 0c3d79bce48034018e840468ac5a642894a521a3 ("tcp: reduce SYN-ACK
> retrans for TCP_DEFER_ACCEPT") introduces syn_ack_recalc() which decides
> if a minisock is held and a SYN+ACK is retransmitted or not.
> 
> If rskq_defer_accept is not zero in syn_ack_recalc(), max_retries always
> has the same value because max_retries is overwritten by rskq_defer_accept
> in reqsk_timer_handler().
> 
> This commit adds three changes:
> - remove redundant non-zero check for rskq_defer_accept in
>    reqsk_timer_handler().
> - remove max_retries from the arguments of syn_ack_recalc() and use
>    rskq_defer_accept instead.
> - rename thresh to max_syn_ack_retries for readability.
> 
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.co.jp>
> Reviewed-by: Benjamin Herrenschmidt <benh@...zon.com>

Applied, thanks.