lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Jul 2020 00:55:10 +0300 From: Petr Machata <petrm@...lanox.com> To: netdev@...r.kernel.org Cc: Pablo Neira Ayuso <pablo@...filter.org>, davem@...emloft.net, kuba@...nel.org, jiri@...lanox.com, petrm@...lanox.com, mlxsw@...lanox.com, michael.chan@...adcom.com, saeedm@...lanox.com, leon@...nel.org, kadlec@...filter.org, fw@...len.de, jhs@...atatu.com, xiyou.wangcong@...il.com, simon.horman@...ronome.com, Ido Schimmel <idosch@...lanox.com> Subject: [PATCH net-next v2 08/13] mlxsw: spectrum_flow: Convert a goto to a return No clean-up is performed at the target label of this goto. Convert it to a direct return. Signed-off-by: Petr Machata <petrm@...lanox.com> Reviewed-by: Jiri Pirko <jiri@...lanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c index 47b66f347ff1..421581a85cd6 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flow.c @@ -219,8 +219,7 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, mlxsw_sp_tc_block_release); if (IS_ERR(block_cb)) { mlxsw_sp_flow_block_destroy(flow_block); - err = PTR_ERR(block_cb); - goto err_cb_register; + return PTR_ERR(block_cb); } register_block = true; } else { @@ -247,7 +246,6 @@ static int mlxsw_sp_setup_tc_block_bind(struct mlxsw_sp_port *mlxsw_sp_port, err_block_bind: if (!flow_block_cb_decref(block_cb)) flow_block_cb_free(block_cb); -err_cb_register: return err; } -- 2.20.1
Powered by blists - more mailing lists