netdev - Re: [PATCH v4] fs/epoll: Enable non-blocking busypoll when epoll timeout is 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0Uf_5v-CEHx24ryawu2UCpFUTLeXkcvNnqnETbhzpoO42Q@mail.gmail.com>
Date:   Sat, 11 Jul 2020 09:05:23 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Sridhar Samudrala <sridhar.samudrala@...el.com>
Cc:     linux-fsdevel@...r.kernel.org, Netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        David Miller <davem@...emloft.net>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        andy.lavr@...il.com
Subject: Re: [PATCH v4] fs/epoll: Enable non-blocking busypoll when epoll
 timeout is 0

On Fri, Jul 10, 2020 at 11:13 PM Sridhar Samudrala
<sridhar.samudrala@...el.com> wrote:
>
> This patch triggers non-blocking busy poll when busy_poll is enabled,
> epoll is called with a timeout of 0 and is associated with a napi_id.
> This enables an app thread to go through napi poll routine once by
> calling epoll with a 0 timeout.
>
> poll/select with a 0 timeout behave in a similar manner.
>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>
> v4:
> - Fix a typo (Andy)
> v3:
> - reset napi_id if no event available after busy poll (Alex)
> v2:
> - Added net_busy_loop_on() check (Eric)
> ---
>  fs/eventpoll.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/fs/eventpoll.c b/fs/eventpoll.c
> index 12eebcdea9c8..10da7a8e1c2b 100644
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c
> @@ -1847,6 +1847,22 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events,
>                 eavail = ep_events_available(ep);
>                 write_unlock_irq(&ep->lock);
>
> +               /*
> +                * Trigger non-blocking busy poll if timeout is 0 and there are
> +                * no events available. Passing timed_out(1) to ep_busy_loop
> +                * will make sure that busy polling is triggered only once.
> +                */
> +               if (!eavail && net_busy_loop_on()) {
> +                       ep_busy_loop(ep, timed_out);
> +
> +                       write_lock_irq(&ep->lock);
> +                       eavail = ep_events_available(ep);
> +                       write_unlock_irq(&ep->lock);
> +
> +                       if (!eavail)
> +                               ep_reset_busy_poll_napi_id(ep);
> +               }
> +
>                 goto send_events;
>         }
>

This addresses the concern that I had.

Reviewed-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>