netdev - Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200711165203.GO1014141@lunn.ch>
Date:   Sat, 11 Jul 2020 18:52:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Rob Herring <robh@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v1 1/1] dt-bindings: net: dsa: Add DSA yaml binding

On Sat, Jul 11, 2020 at 01:35:12PM +0200, Kurt Kanzenbach wrote:
> On Fri Jul 10 2020, Rob Herring wrote:
> > On Fri, 10 Jul 2020 11:06:18 +0200, Kurt Kanzenbach wrote:
> >> For future DSA drivers it makes sense to add a generic DSA yaml binding which
> >> can be used then. This was created using the properties from dsa.txt. It
> >> includes the ports and the dsa,member property.
> >> 
> >> Suggested-by: Florian Fainelli <f.fainelli@...il.com>
> >> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> >> ---
> >>  .../devicetree/bindings/net/dsa/dsa.yaml      | 80 +++++++++++++++++++
> >>  1 file changed, 80 insertions(+)
> >>  create mode 100644 Documentation/devicetree/bindings/net/dsa/dsa.yaml
> >> 
> >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/ti,cpsw-switch.example.dt.yaml: switch@0: 'ports' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.example.dt.yaml: switch@10: 'ports' is a required property
> 
> Okay, the requirement for 'ports' has be to removed.

Hummm....

ti.cpsw is not a DSA switch. So this binding should not apply to
it. It is a plain switchdev switch.

The qcom,ipq806 is just an MDIO bus master. The DSA binding might
apply, for a specific .dts file, if that dts file has a DSA switch on
the bus. But in general, it should not apply.

So i actually think you need to work out why this binding is being
applied when it should not be.

I suspect it is the keyword 'switch'. switch does not imply it is a
DSA switch. There are other sorts of switches as well.

	Andrew