netdev - Re: [PATCH bpf-next] tools/bpftool: remove warning about PID iterator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49d46a96-ad92-90dd-9723-893bd1e5a7bc@fb.com>
Date:   Fri, 10 Jul 2020 19:09:03 -0700
From:   Yonghong Song <yhs@...com>
To:     Andrii Nakryiko <andriin@...com>, <bpf@...r.kernel.org>,
        <netdev@...r.kernel.org>, <ast@...com>, <daniel@...earbox.net>
CC:     <andrii.nakryiko@...il.com>, <kernel-team@...com>,
        Andrey Ignatov <rdna@...com>
Subject: Re: [PATCH bpf-next] tools/bpftool: remove warning about PID iterator
 support



On 7/10/20 4:26 PM, Andrii Nakryiko wrote:
> Don't emit warning that bpftool was built without PID iterator support. This
> error garbles JSON output of otherwise perfectly valid show commands.
> 
> Reported-by: Andrey Ignatov <rdna@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Thanks for the fix.
Acked-by: Yonghong Song <yhs@...com>

> ---
>   tools/bpf/bpftool/pids.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/pids.c b/tools/bpf/bpftool/pids.c
> index c0d23ce4a6f4..e3b116325403 100644
> --- a/tools/bpf/bpftool/pids.c
> +++ b/tools/bpf/bpftool/pids.c
> @@ -15,7 +15,6 @@
>   
>   int build_obj_refs_table(struct obj_refs_table *table, enum bpf_obj_type type)
>   {
> -	p_err("bpftool built without PID iterator support");
>   	return -ENOTSUP;
>   }
>   void delete_obj_refs_table(struct obj_refs_table *table) {}
>