netdev - Re: [PATCH net-next 3/3] net: treewide: Convert to netdev_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dfd5aa8-a765-defa-0c20-abdb2e78a3e0@gmail.com>
Date:   Sun, 12 Jul 2020 15:19:22 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, mkubecek@...e.cz,
        kuba@...nel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 3/3] net: treewide: Convert to netdev_ops_equal()



On 7/12/2020 3:16 PM, Florian Fainelli wrote:
> In order to support overloading of netdev_ops which can be done by
> specific subsystems such as DSA, utilize netdev_ops_equal() which allows
> a network driver implementing a ndo_equal operation to still qualify
> whether a net_device::netdev_ops is equal or not to its own.
> 
> Mechanical conversion done by spatch with the following SmPL patch:
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops != &o
>     + !netdev_ops_equal(n, &o)
> 
>     @@
>     struct net_device *n;
>     const struct net_device_ops o;
>     identifier netdev_ops;
>     @@
> 
>     - n->netdev_ops == &o
>     + netdev_ops_equal(n, &o)
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---

I will be waiting for feedback before spinning a v2, but the changes to
net/openvswitch are no longer necessary and should instead using
__netdev_ops_equal(), sorry for missing that before sending.
-- 
Florian