netdev - Re: [PATCH v3 net-next 3/3] octeontx2-pf: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713132557.GA27934@hoboy>
Date:   Mon, 13 Jul 2020 06:25:57 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     sundeep subbaraya <sundeep.lkml@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        sgoutham@...vell.com, Subbaraya Sundeep <sbhatta@...vell.com>,
        Aleksey Makarov <amakarov@...vell.com>
Subject: Re: [PATCH v3 net-next 3/3] octeontx2-pf: Add support for PTP clock

On Mon, Jul 13, 2020 at 11:40:34AM +0530, sundeep subbaraya wrote:
> > > +static int otx2_ioctl(struct net_device *netdev, struct ifreq *req, int cmd)
> > > +{
> > > +     struct otx2_nic *pfvf = netdev_priv(netdev);
> > > +     struct hwtstamp_config *cfg = &pfvf->tstamp;
> > > +
> >
> > Need to test phy_has_hwtstamp() here and pass ioctl to PHY if true.
> >
> For this platform PHY is taken care of by firmware hence it is not
> possible.

This has nothing to do with the FW.  The HW design might include a PHY
or MII time stamping device.

> > SKBTX_IN_PROGRESS may be set by the PHY, so you need to test whether
> > time stamping is enabled in your MAC driver as well.
> >
> In our case PHY will not set it and the pfvf/MAC driver sets it.

That might be true today, but the MAC driver should not prevent the
possibility of using an external time stamping device in the future.

Thanks,
Richard