netdev - Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713160756.5bd76e1e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 13 Jul 2020 16:07:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Edward Cree <ecree@...arflare.com>
Cc:     <linux-net-drivers@...arflare.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 04/16] sfc_ef100: skeleton EF100 PF driver

On Mon, 13 Jul 2020 12:32:16 +0100 Edward Cree wrote:
> +static int __init ef100_init_module(void)
> +{
> +	int rc;
> +
> +	pr_info("Solarflare EF100 NET driver v" EFX_DRIVER_VERSION "\n");
> +
> +	rc = efx_create_reset_workqueue();
> +	if (rc)
> +		goto err_reset;
> +
> +	rc = pci_register_driver(&ef100_pci_driver);
> +	if (rc < 0) {
> +		pr_err("pci_register_driver failed, rc=%d\n", rc);
> +		goto err_pci;
> +	}
> +
> +	return 0;
> +
> +err_pci:
> +	efx_destroy_reset_workqueue();
> +err_reset:
> +	return rc;
> +}
> +
> +static void __exit ef100_exit_module(void)
> +{
> +	pr_info("Solarflare EF100 NET driver unloading\n");

efx_destroy_reset_workqueue(); ?

> +	pci_unregister_driver(&ef100_pci_driver);
> +}