netdev - Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bcb9020f0a3836f41036ddc3c8034b96e183197.camel@intel.com>
Date:   Tue, 14 Jul 2020 15:58:53 +0000
From:   "Westergreen, Dalon" <dalon.westergreen@...el.com>
To:     "kuba@...nel.org" <kuba@...nel.org>,
        "Ooi, Joyce" <joyce.ooi@...el.com>
CC:     "See, Chin Liang" <chin.liang.see@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Nguyen, Dinh" <dinh.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "thor.thayer@...ux.intel.com" <thor.thayer@...ux.intel.com>,
        "Tan, Ley Foon" <ley.foon.tan@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher



On Tue, 2020-07-14 at 08:55 -0700, Jakub Kicinski wrote:
> On Tue, 14 Jul 2020 14:35:16 +0000 Ooi, Joyce wrote:
> > > I'm no device tree expert but these look like config options rather than
> > > HW
> > > description. They also don't appear to be documented in the next patch.  
> > 
> > The poll_freq are part of the msgdma prefetcher IP, whereby it
> > specifies the frequency of descriptor polling operation. I can add
> > the poll_freq description in the next patch.
> 
> Is the value decided at the time of synthesis or can the driver choose 
> the value it wants?

It is not controlled at synthesis, this parameter should likely not be a
devicetree parameter, perhaps just make it a module parameter with a default
value.

--dalon