netdev - Re: [PATCH net-next 2/2] net: sched: Do not pass root lock Qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875zaqjch0.fsf@mellanox.com>
Date:   Tue, 14 Jul 2020 18:19:39 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH net-next 2/2] net: sched: Do not pass root lock Qdisc_ops.enqueue


Eric Dumazet <eric.dumazet@...il.com> writes:

> On 7/14/20 6:32 AM, Petr Machata wrote:
>> The reason for this was to make visible the dangerous possibility that
>> enqueue drops the lock. The previous patch undoes the lock dropping, and
>> therefore this patch can be reverted.
>> 
>> Signed-off-by: Petr Machata <petrm@...lanox.com>
>
> Wow, I have not seen that this stuff actually went in net-next.
>
> Please make this a proper revert of
> aebe4426ccaa4838f36ea805cdf7d76503e65117 ("net: sched: Pass root lock to Qdisc_ops.enqueue")
>
> git revert aebe4426ccaa4838f36ea805cdf7d76503e65117

Sure.