netdev - Re: [PATCHv3 ipsec-next 06/10] ip6_vti: support IP6IP6 tunnel processing with .cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Jul 2020 03:54:48 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
        kbuild test robot <lkp@...el.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>,
        lkft-triage@...ts.linaro.org,
        Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCHv3 ipsec-next 06/10] ip6_vti: support IP6IP6 tunnel
 processing with .cb_handler

On Wed, Jul 15, 2020 at 1:33 AM Xin Long <lucien.xin@...il.com> wrote:
>
> Thanks
>
> I'll check it soon.
>
>
> On Tue, Jul 14, 2020 at 10:37 PM Naresh Kamboju
> <naresh.kamboju@...aro.org> wrote:
> >
> > On Mon, 6 Jul 2020 at 17:32, Xin Long <lucien.xin@...il.com> wrote:
> > >
> > > Similar to IPIP tunnel's processing, this patch is to support
> > > IP6IP6 tunnel processing with .cb_handler.
> > >
> > > v1->v2:
> > >   - no change.
> > > v2-v3:
> > >   - enable it only when CONFIG_INET6_XFRM_TUNNEL is defined, to fix
> > >     the build error, reported by kbuild test robot.
> > >
> > > Signed-off-by: Xin Long <lucien.xin@...il.com>
> > > ---
> > >  net/ipv6/ip6_vti.c | 33 +++++++++++++++++++++++++++++++++
> > >  1 file changed, 33 insertions(+)
> > >
> > > diff --git a/net/ipv6/ip6_vti.c b/net/ipv6/ip6_vti.c
> > > index 1147f64..39efe41 100644
> > > --- a/net/ipv6/ip6_vti.c
> > > +++ b/net/ipv6/ip6_vti.c
> > > @@ -1218,6 +1218,26 @@ static struct xfrm6_protocol vti_ipcomp6_protocol __read_mostly = {
> > >         .priority       =       100,
> > >  };
> > >
> > > +#if IS_ENABLED(CONFIG_INET6_XFRM_TUNNEL)
This can be fixed by using IS_REACHABLE()

> > > +static int vti6_rcv_tunnel(struct sk_buff *skb)
> > > +{
> > > +       const xfrm_address_t *saddr;
> > > +       __be32 spi;
> > > +
> > > +       saddr = (const xfrm_address_t *)&ipv6_hdr(skb)->saddr;
> > > +       spi = xfrm6_tunnel_spi_lookup(dev_net(skb->dev), saddr);
> >
> > arm build failed due this error on linux-next 20200713 and  20200713
> > 15:51:27 | net/ipv6/ip6_vti.o: In function `vti6_rcv_tunnel':
> > 15:51:27 | ip6_vti.c:(.text+0x1d20): undefined reference to
> > `xfrm6_tunnel_spi_lookup'
> >
> > ref:
> > https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-next/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/812/consoleText
> >
> > config link,
> > http://snapshots.linaro.org/openembedded/lkft/lkft/sumo/am57xx-evm/lkft/linux-next/811/config
> >
> > --
> > Linaro LKFT
> > https://lkft.linaro.org