netdev - Re: [PATCH] qed (qed_int.c) disable "MFW indication via attention" SPAM every 5 minutes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 14:47:18 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     loberman@...hat.com
Cc:     linux-scsi@...r.kernel.org, QLogic-Storage-Upstream@...ium.com,
        netdev@...r.kernel.org, aelior@...vell.com,
        GR-everest-linux-l2@...vell.com
Subject: Re: [PATCH] qed (qed_int.c) disable "MFW indication via attention"
 SPAM every 5 minutes 

From: Laurence Oberman <loberman@...hat.com>
Date: Tue, 14 Jul 2020 09:50:29 -0400

> This is likely firmware causing this but its starting to annoy customers.
> Change the message level to verbose to prevent the spam.
> Note that this seems to only show up with ISCSI enabled on the HBA via the 
> qedi driver.
> 
> Signed-off-by: Laurence Oberman <loberman@...hat.com>

Please... I asked you to look at recent changes to this driver and use
a Subject line consistent with those changes.

And if I do:

	git shortlog v5.6.. -- drivers/net/ethernet/qlogic/qed

I see commit header lines using "qed: " as the subsystem prefix.

So I have to ask, where in recent changes to this driver did you see
examples of people explicitly mentioning "(qed_int.c)" or other file
names?  Where did you see other changes not having a colon character
separating the subsystem prefix from the one-line description?

Please, format this properly:

	[PATCH net] qed: Disable "MFW indictation via attention" SPAM every 5 minutes

For the future, just look at what other developers are doing rather than
inventing your own formatting.

Thank you.