netdev - Re: [PATCH 1/1] ax88172a: fix ax88172a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200713.170859.794084104671494668.davem@davemloft.net>
Date:   Mon, 13 Jul 2020 17:08:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     george.kennedy@...cle.com
Cc:     kuba@...nel.org, dan.carpenter@...cle.com, dhaval.giani@...cle.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures

From: George Kennedy <george.kennedy@...cle.com>
Date: Mon, 13 Jul 2020 07:58:57 -0400

> @@ -237,6 +237,8 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf)
>  
>  free:
>  	kfree(priv);
> +	if (ret >= 0)
> +		ret = -EIO;
>  	return ret;

Success paths reach here, so ">= 0" is not appropriate.  Maybe you
meant "> 0"?