netdev - RE: [PATCH net-next 08/12] liquidio: convert to new udp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BYAPR18MB242321AB3ECD038555C71348AC610@BYAPR18MB2423.namprd18.prod.outlook.com>
Date:   Tue, 14 Jul 2020 01:59:15 +0000
From:   Derek Chickles <dchickles@...vell.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>,
        "simon.horman@...ronome.com" <simon.horman@...ronome.com>,
        "ajit.khaparde@...adcom.com" <ajit.khaparde@...adcom.com>,
        "sriharsha.basavapatna@...adcom.com" 
        <sriharsha.basavapatna@...adcom.com>,
        "somnath.kotur@...adcom.com" <somnath.kotur@...adcom.com>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        Ariel Elior <aelior@...vell.com>,
        Sudarsana Reddy Kalluru <skalluru@...vell.com>,
        "vishal@...lsio.com" <vishal@...lsio.com>,
        "benve@...co.com" <benve@...co.com>,
        "_govind@....com" <_govind@....com>,
        Satananda Burla <sburla@...vell.com>,
        Felix Manlunas <fmanlunas@...vell.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "anthony.l.nguyen@...el.com" <anthony.l.nguyen@...el.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>,
        Shahed Shaikh <shshaikh@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        GR-Linux-NIC-Dev <GR-Linux-NIC-Dev@...vell.com>
Subject: RE: [PATCH net-next 08/12] liquidio: convert to new udp_tunnel_nic
 infra

> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Monday, July 13, 2020 5:31 PM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; oss-drivers@...ronome.com;
> simon.horman@...ronome.com; ajit.khaparde@...adcom.com;
> sriharsha.basavapatna@...adcom.com; somnath.kotur@...adcom.com;
> thomas.lendacky@....com; Ariel Elior <aelior@...vell.com>; Sudarsana
> Reddy Kalluru <skalluru@...vell.com>; vishal@...lsio.com;
> benve@...co.com; _govind@....com; Derek Chickles
> <dchickles@...vell.com>; Satananda Burla <sburla@...vell.com>; Felix
> Manlunas <fmanlunas@...vell.com>; jeffrey.t.kirsher@...el.com;
> anthony.l.nguyen@...el.com; GR-everest-linux-l2 <GR-everest-linux-
> l2@...vell.com>; Shahed Shaikh <shshaikh@...vell.com>; Manish Chopra
> <manishc@...vell.com>; GR-Linux-NIC-Dev <GR-Linux-NIC-
> Dev@...vell.com>; Jakub Kicinski <kuba@...nel.org>
> Subject: [EXT] [PATCH net-next 08/12] liquidio: convert to new
> udp_tunnel_nic infra
> 
> This driver is just a super thin FW interface. Assume it wants 256 ports at
> most. Not much we can do here.

It actually supports 1024. Can you change this patch accordingly? Same goes for lio_vf_main.c.

Thanks,
Derek




> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  .../net/ethernet/cavium/liquidio/lio_main.c   | 59 +++++++++++--------
>  1 file changed, 33 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> index 19689d72bc4e..dc620cb78fd5 100644
> --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
> +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
> @@ -2670,6 +2670,35 @@ static int liquidio_vxlan_port_command(struct
> net_device *netdev, int command,
>  	return ret;
>  }
> 
> +static int liquidio_udp_tunnel_set_port(struct net_device *netdev,
> +					unsigned int table, unsigned int entry,
> +					struct udp_tunnel_info *ti)
> +{
> +	return liquidio_vxlan_port_command(netdev,
> +
> OCTNET_CMD_VXLAN_PORT_CONFIG,
> +					   htons(ti->port),
> +					   OCTNET_CMD_VXLAN_PORT_ADD);
> +}
> +
> +static int liquidio_udp_tunnel_unset_port(struct net_device *netdev,
> +					  unsigned int table,
> +					  unsigned int entry,
> +					  struct udp_tunnel_info *ti)
> +{
> +	return liquidio_vxlan_port_command(netdev,
> +
> OCTNET_CMD_VXLAN_PORT_CONFIG,
> +					   htons(ti->port),
> +					   OCTNET_CMD_VXLAN_PORT_DEL);
> +}
> +
> +static const struct udp_tunnel_nic_info liquidio_udp_tunnels = {
> +	.set_port	= liquidio_udp_tunnel_set_port,
> +	.unset_port	= liquidio_udp_tunnel_unset_port,
> +	.tables		= {
> +		{ .n_entries = 256, .tunnel_types =
> UDP_TUNNEL_TYPE_VXLAN, },
> +	},
> +};