lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jul 2020 10:01:45 -0400 From: George Kennedy <george.kennedy@...cle.com> To: David Miller <davem@...emloft.net> Cc: dan.carpenter@...cle.com, kuba@...nel.org, dhaval.giani@...cle.com, netdev@...r.kernel.org Subject: Re: [PATCH 1/1] ax88172a: fix ax88172a_unbind() failures On 7/14/2020 5:37 PM, David Miller wrote: > From: George Kennedy <george.kennedy@...cle.com> > Date: Tue, 14 Jul 2020 17:34:33 -0400 > >> For example, the failing case here has "ret" = 0 (#define ETH_ALEN 6): >> >> 172 static int ax88172a_bind(struct usbnet *dev, struct >> usb_interface *intf) >> 173 { >> ... >> 186 /* Get the MAC address */ >> 187 ret = asix_read_cmd(dev, AX_CMD_READ_NODE_ID, 0, 0, >> ETH_ALEN, buf, 0); >> 188 if (ret < ETH_ALEN) { >> 189 netdev_err(dev->net, "Failed to read MAC >> address: %d\n", ret); >> 190 goto free; >> 191 } >> "drivers/net/usb/ax88172a.c" > Then this is the spot that should set 'ret' to -EINVAL or similar? Made the suggested fix and sent the updated patch with following: Subject: [PATCH v2 1/1] ax88172a: fix ax88172a_unbind() failures George
Powered by blists - more mailing lists