netdev - Re: [EXT] Re: [PATCH] net: atlantic: Add support for firmware v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <226601b2-562c-ae59-ee0d-51b130255c18@marvell.com>
Date:   Wed, 15 Jul 2020 18:34:31 +0300
From:   Igor Russkikh <irusskikh@...vell.com>
To:     David Miller <davem@...emloft.net>,
        Alexander Lobakin <alobakin@...vell.com>
CC:     <kai.heng.feng@...onical.com>, <anthony.wong@...onical.com>,
        <kuba@...nel.org>, Nikita Danilov <ndanilov@...vell.com>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bezrukov <dbezrukov@...vell.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] Re: [PATCH] net: atlantic: Add support for firmware v4


>>> We have a new ethernet card that is supported by the atlantic driver:
>>> 01:00.0 Ethernet controller [0200]: Aquantia Corp. AQC107 NBase-T/IEEE
> 802.3bz Ethernet Controller [AQtion] [1d6a:07b1] (rev 02)
>>>
>>> But the driver failed to probe the device:
>>> kernel: atlantic: Bad FW version detected: 400001e
>>> kernel: atlantic: probe of 0000:01:00.0 failed with error -95
>>>
>>> As a pure guesswork, simply adding the firmware version to the driver
>>
>> Please don't send "pure guessworks" to net-fixes tree. You should have
>> reported this as a bug to LKML and/or atlantic team, so we could issue
>> it.
> 
> Production hardware is shipping to customers and the driver
> maintainers didn't add support for this ID yet?  What is that
> "atlantic team" waiting for?
> 
> Honestly I don't blame someone for posting a patch like this to get it
> to work.

Me too ;)

We've discussed this with Kai Heng internally, that was really an engineering
sample.

We'll repost this patch soon with some more changes required for that new FW.

Thanks,
  Igor