lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Wed, 15 Jul 2020 16:47:52 +0000 (UTC)
From:   Kalle Valo <>
To:     "Saheed O. Bolarinwa" <>
Cc:,,,, Stanislaw Gruszka <>,,,
        Bolarinwa Olayemi Saheed <>
Subject: Re: [PATCH 4/14 v3] iwlegacy: Check the return value of

"Saheed O. Bolarinwa" <> wrote:

> From: Bolarinwa Olayemi Saheed <>
> On failure pcie_capability_read_dword() sets it's last parameter, val
> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
> failure. This would introduce a bug because (x & x) == (~0 & x).
> This bug can be avoided without changing the function's behaviour if the
> return value of pcie_capability_read_dword is checked to confirm success.
> Check the return value of pcie_capability_read_dword() to ensure success.
> Suggested-by: Bjorn Helgaas <>
> Signed-off-by: Bolarinwa Olayemi Saheed <>

Patch applied to wireless-drivers-next.git, thanks.

9018fd7f2a73 iwlegacy: Check the return value of pcie_capability_read_*()


Powered by blists - more mailing lists