netdev - Re: [PATCH net-next] docs: networking: timestamping: replace tabs with spaces in code blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200715192900.GH12769@casper.infradead.org>
Date:   Wed, 15 Jul 2020 20:29:00 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Vladimir Oltean <olteanv@...il.com>,
        Jonathan Corbet <corbet@....net>, netdev@...r.kernel.org,
        davem@...emloft.net, richardcochran@...il.com, sorganov@...il.com,
        andrew@...n.ch, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next] docs: networking: timestamping: replace tabs
 with spaces in code blocks

On Wed, Jul 15, 2020 at 12:17:17PM -0700, Jakub Kicinski wrote:
> On Thu,  9 Jul 2020 23:22:10 +0300 Vladimir Oltean wrote:
> > Reading the document in vim is currently not a pleasant experience. Its
> > rst syntax highlighting is confused by the "*/" sequences which it's not
> > interpreting as part of the code blocks for some reason.
> > 
> > Replace the tabs with spaces, so that syntax highlighters (at least the
> > one in vim) have a better idea where code blocks start and where they
> > end.
> > 
> > Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> 
> Dunno about this change, there seems to be plenty examples of using
> tabs for indentation of code block :(
> 
> Jon, any guidance? It seems to me the document renders correctly [1],
> so the onus is on the editor to fix the RST highlight..

vim's rst mode really really really wants to use spaces instead of tabs.
It's screwed me over a bunch of times, so I eventually just disabled it.
I think we should probably stop fighting it and use spaces in rst files
instead of tabs, but that's not my call to make.