netdev - Re: [PATCH net-next v2 0/3] make nf_ct_frag/6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200715132659.34fa0e14@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 15 Jul 2020 13:26:59 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     wenxu@...oud.cn
Cc:     netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
        fw@...len.de, Cong Wang <xiyou.wangcong@...il.com>
Subject: Re: [PATCH net-next v2 0/3] make nf_ct_frag/6_gather elide the skb
 CB clear

On Tue,  7 Jul 2020 12:55:08 +0800 wenxu@...oud.cn wrote:
> From: wenxu <wenxu@...oud.cn>
> 
> Add nf_ct_frag_gather and Make nf_ct_frag6_gather elide the CB clear 
> when packets are defragmented by connection tracking. This can make
> each subsystem such as br_netfilter, openvswitch, act_ct do defrag
> without restore the CB. 
> This also avoid serious crashes and problems in  ct subsystem.
> Because Some packet schedulers store pointers in the qdisc CB private
> area and parallel accesses to the SKB.
> 
> This series following up
> http://patchwork.ozlabs.org/project/netdev/patch/1593422178-26949-1-git-send-email-wenxu@ucloud.cn/
> 
> patch1: add nf_ct_frag_gather elide the CB clear
> patch2: make nf_ct_frag6_gather elide the CB clear
> patch3: fix clobber qdisc_skb_cb in act_ct with defrag
> 
> v2: resue some ip_defrag function in patch1

Florian, Cong - are you willing to venture an ack on these? Anyone?