netdev - Re: [PATCH net-next] bareudp: Reverted support to enable & disable rx metadata collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200715134347.6a9324ce@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 15 Jul 2020 13:43:47 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, gnault@...hat.com,
        Martin Varghese <martin.varghese@...ia.com>
Subject: Re: [PATCH net-next] bareudp: Reverted support to enable & disable
 rx metadata collection

On Wed, 15 Jul 2020 08:42:40 +0530 Martin Varghese wrote:
> From: Martin Varghese <martin.varghese@...ia.com>
> 
> The commit fe80536acf83 ("bareudp: Added attribute to enable & disable
> rx metadata collection") breaks the the original(5.7) default behavior of
> bareudp module to collect RX metadadata at the receive. It was added to
> avoid the crash at the kernel neighbour subsytem when packet with metadata
> from bareudp is processed. But it is no more needed as the
> commit 394de110a733 ("net: Added pointer check for
> dst->ops->neigh_lookup in dst_neigh_lookup_skb") solves this crash.
> 
> Fixes: fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection")
> Signed-off-by: Martin Varghese <martin.varghese@...ia.com>

Looks like you didn't remove the mention of the RX_COLLECT_METADATA
flag from the documentation - is this intentional?