netdev - Re: [PATCH] ipvs:clean code for ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200715150336.711be40a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 15 Jul 2020 15:03:36 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     zhouxudong199 <zhouxudong8@...wei.com>
Cc:     <wensong@...ux-vs.org>, <horms@...ge.net.au>,
        <netdev@...r.kernel.org>, <lvs-devel@...r.kernel.org>,
        <rose.chen@...wei.com>
Subject: Re: [PATCH] ipvs:clean code for ip_vs_sync.c

On Wed, 15 Jul 2020 12:18:39 +0000 zhouxudong199 wrote:
> Signed-off-by:zhouxudong199 <zhouxudong8@...wei.com>

Thank you for the patch.

Please describe the changes you're making in the commit message, as far
as I can tell you're adding missing spaces?

Please read this: https://kernelnewbies.org/KernelJanitors
and make sure to CC kernel-janitors@...r.kernel.org

Please add a space after ipvs: in the subject and after Signed-off-by:

If you repost please make sure to mark the patch as v2.

> @@ -1232,7 +1232,7 @@ static void ip_vs_process_message(struct netns_ipvs *ipvs, __u8 *buffer,
>  		msg_end = buffer + sizeof(struct ip_vs_sync_mesg);
>  		nr_conns = m2->nr_conns;
>  
> -		for (i=0; i<nr_conns; i++) {
> +		for (i=0; i < nr_conns; i++) {

you should probably replace i=0 with i = 0.

>  			union ip_vs_sync_conn *s;
>  			unsigned int size;
>  			int retc;