netdev - Re: [PATCH bpf-next] bpf: Add bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+Tc30JvwjZ-sbmmViMyaCb3HAS9f4RQ8utjfS8FnLOOw@mail.gmail.com>
Date:   Wed, 15 Jul 2020 16:56:10 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] bpf: Add bpf_prog iterator

On Wed, Jul 1, 2020 at 10:23 PM Yonghong Song <yhs@...com> wrote:
>
>
>
> On 7/1/20 6:40 PM, Alexei Starovoitov wrote:
> > From: Alexei Starovoitov <ast@...nel.org>
> >
> > It's mostly a copy paste of commit 6086d29def80 ("bpf: Add bpf_map iterator")
> > that is use to implement bpf_seq_file opreations to traverse all bpf programs.
>
> Thanks for implementing bpf iter for bpf_progs!
>
> >
> > Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> > ---
> > No selftests?!
> > They're coming as part of "usermode_driver for iterators" set.
> > This patch is trivial and independent, so sending it first.
>
> Okay. Ack only with a few nits.
> Acked-by: Yonghong Song <yhs@...com>

Thanks for the review. Will be fixed in the next version.