netdev - Re: [PATCH 3/4] cdc_ncm: replace the way cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9219015-6157-495f-0cbc-08cb078aab78@gmail.com>
Date:   Thu, 16 Jul 2020 11:19:54 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Wxcafé <wxcafe@...afe.net>,
        linux-usb@...r.kernel.org
Cc:     Miguel Rodríguez Pérez <miguel@....uvigo.gal>,
        oliver@...kum.org, netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] cdc_ncm: replace the way cdc_ncm hooks into

Hello!

On 15.07.2020 18:56, Wxcafé wrote:

>  From 352445fcbac243b8f10e1840726d67b41a45853d Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Miguel Rodr=C3=ADguez P=C3=A9rez? <miguel@....uvigo.gal>

   Something went wrong

> Date: Tue, 14 Jul 2020 18:10:34 -0400
> Subject: [PATCH 3/4] cdc_ncm: replace the way cdc_ncm hooks into
>   usbnet_change_mtu

    You don't need the above, except for From:...

> Previously cdc_ncm overwrited netdev_ops used by usbnet

    Overwrote.

> thus preventing hooking into set_rx_mode. This patch
> preserves usbnet hooks into netdev_ops, and add an
> additional one for change_mtu needed by cdc_ncm.
> 
> Signed-off-by: Miguel Rodríguez Pérez <miguel@....uvigo.gal>
> Signed-off-by: Wxcafé <wxcafe@...afe.net>
[...]

MBR, Sergei