netdev - Re: [PATCH net-next] mptcp: silence warning in subflow_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3e97692a-4fa2-9b39-e31a-96deae6f5a57@tessares.net>
Date:   Thu, 16 Jul 2020 11:52:45 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        mptcp@...ts.01.org
Subject: Re: [PATCH net-next] mptcp: silence warning in subflow_data_ready()

Hi Davide,

On 15/07/2020 22:27, Davide Caratti wrote:
> since commit d47a72152097 ("mptcp: fix race in subflow_data_ready()"), it
> is possible to observe a regression in MP_JOIN kselftests. For sockets in
> TCP_CLOSE state, it's not sufficient to just wake up the main socket: we
> also need to ensure that received data are made available to the reader.
> Silence the WARN_ON_ONCE() in these cases: it preserves the syzkaller fix
> and restores kselftests	when they are ran as follows:
> 
>    # while true; do
>    > make KBUILD_OUTPUT=/tmp/kselftest TARGETS=net/mptcp kselftest
>    > done
> 
> Reported-by: Florian Westphal <fw@...len.de>
> Fixes: d47a72152097 ("mptcp: fix race in subflow_data_ready()")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/47
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Thank you for the patch!
It looks good to me and it fixes the kselftests on my side as well!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net