netdev - Re: 答复: [PATCH v2] ipvs: clean code for ip_vs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 13:23:22 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     "Zhouxudong (EulerOS)" <zhouxudong8@...wei.com>
Cc:     Suraj Upadhyay <usuraj35@...il.com>,
        "wensong@...ux-vs.org" <wensong@...ux-vs.org>,
        "horms@...ge.net.au" <horms@...ge.net.au>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "lvs-devel@...r.kernel.org" <lvs-devel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "Chenxiang (EulerOS)" <rose.chen@...wei.com>,
        "Zhaowei (EulerOS)" <zhaowei23@...wei.com>
Subject: Re: 答复: [PATCH v2] ipvs: clean code
 for ip_vs_sync.c

It's probably better to start somewhere like drivers/staging for clean
up work.  Networking people are pretty busy with their own things but
staging is happy to take clean up patches.

You need to use a proper legal name (like you would for signing
documents for your From and Signed-off-by.

> > @@ -1444,7 +1444,7 @@ static int bind_mcastif_addr(struct socket *sock, struct net_device *dev)
> >  	sin.sin_addr.s_addr  = addr;
> >  	sin.sin_port         = 0;
> 
> I think you missed this one.
> should be
> -        sin.sin_port         = 0;
> +	 sin.sin_port = 0

That was done deliberately.  Just leave that one as-is, please.

regards,
dan carpenter