netdev - Re: [PATCH net-next v2] bareudp: Reverted support to enable & disable rx metadata collection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Jul 2020 18:27:15 +0200
From:   Guillaume Nault <gnault@...hat.com>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Martin Varghese <martin.varghese@...ia.com>
Subject: Re: [PATCH net-next v2] bareudp: Reverted support to enable &
 disable rx metadata collection

On Thu, Jul 16, 2020 at 09:28:54PM +0530, Martin Varghese wrote:
> From: Martin Varghese <martin.varghese@...ia.com>
> 
> The commit fe80536acf83 ("bareudp: Added attribute to enable & disable
> rx metadata collection") breaks the the original(5.7) default behavior of
> bareudp module to collect RX metadadata at the receive. It was added to
> avoid the crash at the kernel neighbour subsytem when packet with metadata
> from bareudp is processed. But it is no more needed as the
> commit 394de110a733 ("net: Added pointer check for
> dst->ops->neigh_lookup in dst_neigh_lookup_skb") solves this crash.

This patch looks like a complete revert of fe80536acf83, but with a
missing chunk (the rx_collect_metadata field in include/net/bareudp.h).

Why not generating this patch with "git revert fe80536acf83", instead
of doing it manually?. That'd make sure that no chunk is forgotten.

> Fixes: fe80536acf83 ("bareudp: Added attribute to enable & disable rx metadata collection")
> Signed-off-by: Martin Varghese <martin.varghese@...ia.com>