netdev - Re: [PATCH iproute2-next v2 2/2] tc: q_red: Implement has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mu3zifgd.fsf@mellanox.com>
Date:   Thu, 16 Jul 2020 18:37:22 +0200
From:   Petr Machata <petrm@...lanox.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH iproute2-next v2 2/2] tc: q_red: Implement has_block for RED


Jiri Pirko <jiri@...nulli.us> writes:

> Thu, Jul 16, 2020 at 05:49:46PM CEST, petrm@...lanox.com wrote:
>>In order for "tc filter show block X" to find a given block, implement the
>>has_block callback.
>>
>>Signed-off-by: Petr Machata <petrm@...lanox.com>
>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Actually it's broken. When there are several qdiscs, the latter one's
result overwrites the previous one.