netdev - Re: [PATCH v3 bpf-next 9/9] bpf, xdp: remove XDP_QUERY_PROG and XDP_QUERY_PROG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bza_Sr6XcFQpP5jgYLt03CDVXR7zUv2cjNBMSWFqaWZDGQ@mail.gmail.com>
Date:   Thu, 16 Jul 2020 10:00:03 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Ahern <dsahern@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 9/9] bpf, xdp: remove XDP_QUERY_PROG and
 XDP_QUERY_PROG_HW XDP commands

On Thu, Jul 16, 2020 at 8:23 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 15 Jul 2020 21:56:01 -0700 Andrii Nakryiko wrote:
> > Now that BPF program/link management is centralized in generic net_device
> > code, kernel code never queries program id from drivers, so
> > XDP_QUERY_PROG/XDP_QUERY_PROG_HW commands are unnecessary.
> >
> > This patch removes all the implementations of those commands in kernel, along
> > the xdp_attachment_query().
> >
> > This patch was compile-tested on allyesconfig.
> >
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c: In function ‘dpaa2_eth_xdp’:
> drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2079:25: warning: unused variable ‘priv’ [-Wunused-variable]
>  2079 |  struct dpaa2_eth_priv *priv = netdev_priv(dev);
>       |                         ^~~~
>

Oh, I've fixed a few such warnings already, but apparently missed the
last one. It's hard to notice those in allyesconfig build. I've
double-checked the build log with grep now, it seems like there are no
more warnings anymore, thanks!