netdev - Re: [PATCH] net: cxgb3: add missed destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <486de368-03d5-e168-038a-ae1506616703@web.de>
Date:   Fri, 17 Jul 2020 21:18:38 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wang Hai <wanghai38@...wei.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Vishal Kulkarni <vishal@...lsio.com>,
        Santosh Raspatur <santosh@...lsio.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Divy Le Ray <divy@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe
 failure

> Add the missed calls to fix it.

You propose to add only a single function call.


…
> +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c
> @@ -3407,6 +3407,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>  out_disable_device:
>  	pci_disable_device(pdev);
>  out:
> +	destroy_workqueue(cxgb3_wq);
>  	return err;
>  }

I suggest to adjust also the usage of the label “out” accordingly.

Regards,
Markus