netdev - Re: [PATCH v5 net] rtnetlink: Fix memory(net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200717.124009.223867297363163990.davem@davemloft.net>
Date:   Fri, 17 Jul 2020 12:40:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     chenweilong@...wei.com
Cc:     kuba@...nel.org, jiri@...lanox.com, edumazet@...gle.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 net] rtnetlink: Fix memory(net_device) leak when
 ->newlink fails

From: Weilong Chen <chenweilong@...wei.com>
Date: Wed, 15 Jul 2020 20:58:10 +0800

> When vlan_newlink call register_vlan_dev fails, it might return error
> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should
> free the memory. But currently rtnl_newlink only free the memory which
> state is NETREG_UNINITIALIZED.
 ...
> Fixes: cb626bf566eb ("net-sysfs: Fix reference count leak")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>

Applied and queued up for -stable, thanks.