netdev - RE: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02874ECE860811409154E81DA85FBB58C8ABA9D9@ORSMSX151.amr.corp.intel.com>
Date:   Fri, 17 Jul 2020 21:00:56 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kubakici@...pl>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...nulli.us>,
        Tom Herbert <tom@...bertland.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Michael Chan <michael.chan@...adcom.com>,
        Bin Luo <luobin9@...wei.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>,
        Ido Schimmel <idosch@...lanox.com>,
        Danielle Ratson <danieller@...lanox.com>
Subject: RE: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update
 library

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Jakub Kicinski
> Sent: Friday, July 17, 2020 12:58 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: netdev@...r.kernel.org; Jiri Pirko <jiri@...nulli.us>; Tom Herbert
> <tom@...bertland.com>; Jiri Pirko <jiri@...lanox.com>; Jakub Kicinski
> <kuba@...nel.org>; Jonathan Corbet <corbet@....net>; Michael Chan
> <michael.chan@...adcom.com>; Bin Luo <luobin9@...wei.com>; Saeed
> Mahameed <saeedm@...lanox.com>; Leon Romanovsky <leon@...nel.org>;
> Ido Schimmel <idosch@...lanox.com>; Danielle Ratson
> <danieller@...lanox.com>
> Subject: Re: [RFC PATCH net-next v2 0/6] introduce PLDM firmware update
> library
> 
> On Fri, 17 Jul 2020 11:35:35 -0700 Jacob Keller wrote:
> > This series goal is to enable support for updating the ice hardware flash
> > using the devlink flash command.
> 
> Looks reasonable.
> 
> You have some left over references to ignore_pending_flash_update in
> comments, and you should use NLA_POLICY_RANGE() for the new attr.
> 

Ah, good point I'll make sure to fix those up, and switch the NLA_POLICY_RANGE.

> Taking and releasing the FW lock may be fun for multi-host devices if
> you ever support those.

Yea. The lib/pldm stuff assumes the driver will manage the locking. I'm not sure how the resource locks work in a multi-host environment at all..

Thanks,
Jake