netdev - Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALHRZupxX5Cbvb03s-xxA7gobjwo8cM7n4_-U6oGysU3R18-Bw@mail.gmail.com>
Date:   Fri, 17 Jul 2020 10:41:49 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Subbaraya Sundeep <sbhatta@...vell.com>,
        David Miller <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>,
        netdev@...r.kernel.org, sgoutham@...vell.com,
        Aleksey Makarov <amakarov@...vell.com>
Subject: Re: [PATCH v4 net-next 3/3] octeontx2-pf: Add support for PTP clock

Hi Jakub,

On Fri, Jul 17, 2020 at 5:41 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 15 Jul 2020 18:08:09 +0530 Subbaraya Sundeep wrote:
> > @@ -1730,10 +1745,149 @@ static void otx2_reset_task(struct work_struct *work)
> >       if (!netif_running(pf->netdev))
> >               return;
> >
> > +     rtnl_lock();
> >       otx2_stop(pf->netdev);
> >       pf->reset_count++;
> >       otx2_open(pf->netdev);
> >       netif_trans_update(pf->netdev);
> > +     rtnl_unlock();
> > +}
> > +
>
> This looks unrelated, otherwise for the patches:
You mean the lock/unlock logic with this patch?
I can separate this out and put in another patch #4 if you insist.

Thanks,
Sundeep

>
> Acked-by: Jakub Kicinski <kuba@...nel.org>