netdev - Re: [PATCH] mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b480613d-9ff5-79de-1066-2ece999d516d@web.de>
Date:   Sat, 18 Jul 2020 17:20:06 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     Navid Emamdoost <emamd001@....edu>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Jakub Kicinski <kuba@...nel.org>, Felix Fietkau <nbd@....name>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mt76: mt76u: add missing release on skb in
 __mt76x02u_mcu_send_msg

…
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c
…
> @@ -111,6 +113,7 @@ __mt76x02u_mcu_send_msg(struct mt76_dev *dev, struct sk_buff *skb,
>  	if (wait_resp)
>  		ret = mt76x02u_mcu_wait_resp(dev, seq);
>
> +out:
>  	consume_skb(skb);
…

I suggest to use the label “consume_skb”.

Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus