lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Jul 2020 18:34:59 -0700 (PDT) From: David Miller <davem@...emloft.net> To: kuba@...nel.org Cc: netdev@...r.kernel.org, linux-net-drivers@...arflare.com, ecree@...arflare.com, mhabets@...arflare.com, mslattery@...arflare.com Subject: Re: [PATCH net-next] efx: convert to new udp_tunnel infrastructure From: Jakub Kicinski <kuba@...nel.org> Date: Fri, 17 Jul 2020 16:53:36 -0700 > Check MC_CMD_DRV_ATTACH_EXT_OUT_FLAG_TRUSTED, before setting > the info, which will hopefully protect us from -EPERM errors > the previous code was gracefully ignoring. Shared code reports > the port information back to user space, so we really want > to know what was added and what failed. > > The driver does not call udp_tunnel_get_rx_info(), so its own > management of table state is not really all that problematic, > we can leave it be. This allows the driver to continue with its > copious table syncing, and matching the ports to TX frames, > which it will reportedly do one day. > > Leave the feature checking in the callbacks, as the device may > remove the capabilities on reset. > > Inline the loop from __efx_ef10_udp_tnl_lookup_port() into > efx_ef10_udp_tnl_has_port(), since it's the only caller now. > > With new infra this driver gains port replace - when space frees > up in a full table a new port will be selected for offload. > Plus efx will no longer sleep in an atomic context. > > Signed-off-by: Jakub Kicinski <kuba@...nel.org> Edward et al., please review. Thank you.
Powered by blists - more mailing lists