netdev - Re: [PATCH net-next] net: dsa: use the ETH_MIN_MTU and ETH_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 18 Jul 2020 11:43:02 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>, kuba@...nel.org,
        davem@...emloft.net, netdev@...r.kernel.org
Cc:     andrew@...n.ch, vivien.didelot@...il.com, noodles@...th.li,
        mnhagan88@...il.com
Subject: Re: [PATCH net-next] net: dsa: use the ETH_MIN_MTU and ETH_DATA_LEN
 default values



On 7/18/2020 11:04 AM, Vladimir Oltean wrote:
> Now that DSA supports MTU configuration, undo the effects of commit
> 8b1efc0f83f1 ("net: remove MTU limits on a few ether_setup callers") and
> let DSA interfaces use the default min_mtu and max_mtu specified by
> ether_setup(). This is more important for min_mtu: since DSA is
> Ethernet, the minimum MTU is the same as of any other Ethernet
> interface, and definitely not zero. For the max_mtu, we have a callback
> through which drivers can override that, if they want to.
> 
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian